-
Notifications
You must be signed in to change notification settings - Fork 35.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Check an invalid -i2psam will raise an init error #24687
test: Check an invalid -i2psam will raise an init error #24687
Conversation
Looks good to me, thanks |
dc770a2
to
45e67b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review ACK 45e67b2
Tested locally. Test passes with invalid -i2psam
value and fails (hangs) as with onion and proxy with valid values.
PGP Signature
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Code review ACK 45e67b2
Tested locally. Test passes with invalid `-i2psam` value and fails (hangs) as with onion and proxy with valid values.
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEKPWQCxu10aS2ttGp7TVwFShqMz0FAmJAnOYACgkQ7TVwFShq
Mz0z9g/9E2v2pao2/X2cyk6BkZwuFuuH0O5Pbt2votwGJZ17UbE5jbw4Pvk2HsNB
zo8Lp6/XBXYQX9Z6xoRI3oCS/oPFrhKwLlKGwDx71PAkt5URChyli0Q5G/yzZmKX
nAtQoO+kmCaa/wWsc9aspgW9u8jC7O7kWZ201gwZyIlyHDWQlKuLeMqMLBAT6IQ8
8tfXGNg7LAJph0caQ9aCGgwXHikg43Cjh3jpcl9tVcvlGAbrlPs2EBXk8LGPdsRC
SSU0OMUj8Zqrlnqj42unywi2U3r7pQd6sQ7gEaqWQrLsCh/jzOq3tXFzw7ryRuFk
17+ULDOhaUXPLb6zE/YYZI+6XWjuAY2CYZKph0y6mbrcEIwXz4yxX+4eAsbkEHG1
duyzEfnLMw+/8v4ordvyGM39a4gbctF6GaIqh6zUzAQSOBeXYwGhhChcXWstfjVv
7dHlkixJz1v3sc5drIh3Ffbn77RhZrpEmaz2c4HeyeI4HwGXvgTtoK1/anK6GHRG
BCqh3beUUHxy+5qVzva1JyfuVpdzbsbGJIhlr9XTDwx0WELg46GPBYSBS5BbDLSb
WhNlWIB0qVLtKBFZo4nasHYksmX7wtZmrlRyHqugSiBEhx2x1v3SOyrxT+qaC7cU
ED60H+6YXKeVoviIJLuLjqq7sSMxhHKapQJcUZaViQ18qhpug9c=
=rVAT
-----END PGP SIGNATURE-----
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post-merge ACK
…t error 45e67b2 test: invalid -i2psam will raise an init error (brunoerg) Pull request description: This PR adds test coverage (at `feature_proxy.py`) for the following init error: https://github.com/bitcoin/bitcoin/blob/2f0f056e08cd5a1435120592a9ecd212fcdb915b/src/init.cpp#L1791 It starts the node with an invalid -i2psam (`-i2psam=invalidhere`) and test if it raises an error when initializing. ACKs for top commit: dunxen: Code review ACK 45e67b2 Tree-SHA512: b24e3f6e7a9316b9ebc0b6c8bcf1315faff60a9e258d7bb3dbeb9f6695a728bb3083aea2f81114072fe13822bfca34d4a0f44f229825f7c97a81619d810010c0
Github-Pull: bitcoin#24687 Rebased-From: 45e67b2
This PR adds test coverage (at
feature_proxy.py
) for the following init error:bitcoin/src/init.cpp
Line 1791 in 2f0f056
It starts the node with an invalid -i2psam (
-i2psam=invalidhere
) and test if it raises an error when initializing.